Skip to content

London | ITP - Jan-2026 | Ping Wang | Sprint 2 | coursework#935

Open
pathywang wants to merge 23 commits intoCodeYourFuture:mainfrom
pathywang:coursework/sprint-2
Open

London | ITP - Jan-2026 | Ping Wang | Sprint 2 | coursework#935
pathywang wants to merge 23 commits intoCodeYourFuture:mainfrom
pathywang:coursework/sprint-2

Conversation

@pathywang
Copy link

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

After i study prep with notes, i completed coursework with node to check my code on my example2.js file. What is more, i made notes on my notebook to review later because i did get some help from AI tool and hopefully i can do on my own without any help next time

@pathywang pathywang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

// =============> write your explanation here
// =============> write your new code here
// the input "str" is the same as output "str" which is not allowed in JS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ability to describe and explain code using proper terminology is essential for a software developer.

"str" is neither an input or output. Can you rephrase the statement on line 12?

Feel free to use AI to help you learn how to describe or explain code, and take note of the terminology it suggests.

Comment on lines 13 to 16
// So, we’ll see:csharp
// Copy
// Edit
// 320
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these "csharp", "Copy", ...?

} No newline at end of file
function calculateBMI(weight, height) {
const bmi= weight/(height*height);
return bmi.toFixed(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

  console.log(123);              // Output 123
  console.log("123");            // Output 123
  
  // Treated differently in the program
  let sum1 = 123 + 100;         // Evaluate to 223 -- a number
  let sum 2 = "123" + 100;      // Evaluate to "123100" -- a string.

// The function to convert any string to UPPER_SNAKE_CASE:

function toUpperSnakeCase(input) {
return input.trim().toUpperCase().replace(/\s+/g, "_");}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Common practice is the place the closing } by itself on a separate line.

If you install "prettier" extension on VSCode, you can also use VSCode "Format Document" feature to auto indent JS code.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 16, 2026
@pathywang pathywang added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 16, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 17, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants